Add nixexplore command line tool #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Achilleas Koutsou <[email protected]>
Co-authored-by: Achilleas Koutsou <[email protected]>
Co-authored-by: Achilleas Koutsou <[email protected]>
Co-authored-by: Achilleas Koutsou <[email protected]>
if not given, data is dumped to stdout and the progress bar is not shown.
achilleas-k
requested changes
Aug 7, 2020
There was a problem hiding this comment.
Since a separate progress bar is printed for each array, I think it should be indicated somehow. Something like "dumping array" or "dumping [name of array]". Otherwise it gives the impression that it's the entire progress and it can be confusing when the bar resets and runs through multiple times.
|
Looks good. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebased replacement of pull request for #461