Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Interpreter::execute and friends generic over predicate-ness #920

Merged
merged 6 commits into from
Feb 26, 2025

Conversation

Dentosal
Copy link
Member

@Dentosal Dentosal commented Feb 26, 2025

Force monomorphization of the execute family of functions over predicate vs non-predicate execution. This allows optimizing a branch from the hot VM main loop.

Originally from FuelLabs/fuel-core#2767 (comment).

Also bumps Rust version in CI to 1.81.0.

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • If performance characteristic of an instruction change, update gas costs as well or make a follow-up PR for that
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

@Dentosal Dentosal self-assigned this Feb 26, 2025
Copy link
Collaborator

@xgreenx xgreenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you swapped boolean variables=D

xgreenx
xgreenx previously approved these changes Feb 26, 2025
@Dentosal Dentosal marked this pull request as ready for review February 26, 2025 21:14
@Dentosal Dentosal enabled auto-merge February 26, 2025 21:26
@Dentosal Dentosal requested a review from a team February 26, 2025 21:31
@Dentosal Dentosal added this pull request to the merge queue Feb 26, 2025
Merged via the queue into master with commit 4af1be6 Feb 26, 2025
39 checks passed
@Dentosal Dentosal deleted the dento/const-predicate-ctx-execute branch February 26, 2025 22:27
@Dentosal Dentosal mentioned this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants