Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: allow releases to NPM #916

Merged
merged 2 commits into from
Feb 19, 2025
Merged

chore: allow releases to NPM #916

merged 2 commits into from
Feb 19, 2025

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Feb 19, 2025 •
edited
Loading

This change will provide the token required to deploy to NPM.

Note

This step required manual approval before the workflow runs.

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • If performance characteristic of an instruction change, update gas costs as well or make a follow-up PR for that
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

@petertonysmith94 petertonysmith94 added the no changelog Skips the CI changelog check label Feb 19, 2025
@petertonysmith94 petertonysmith94 self-assigned this Feb 19, 2025
xgreenx
xgreenx previously approved these changes Feb 19, 2025
View reviewed changes
AurelienFT
AurelienFT previously approved these changes Feb 19, 2025
View reviewed changes
@petertonysmith94 petertonysmith94 dismissed stale reviews from AurelienFT and xgreenx via ed9c810 February 19, 2025 19:16
@AurelienFT AurelienFT enabled auto-merge February 19, 2025 19:23
@AurelienFT AurelienFT added this pull request to the merge queue Feb 19, 2025
Merged via the queue into master with commit 9478991 Feb 19, 2025
39 checks passed
@AurelienFT AurelienFT deleted the ps/chore/allow-release-to-npm branch February 19, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchristopher mchristopher mchristopher approved these changes

@AurelienFT AurelienFT AurelienFT approved these changes

@Dentosal Dentosal Awaiting requested review from Dentosal Dentosal is a code owner

@MitchTurner MitchTurner Awaiting requested review from MitchTurner MitchTurner is a code owner

@Voxelot Voxelot Awaiting requested review from Voxelot Voxelot is a code owner

@xgreenx xgreenx Awaiting requested review from xgreenx xgreenx is a code owner

Assignees

@petertonysmith94 petertonysmith94

Labels
no changelog Skips the CI changelog check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@petertonysmith94 @mchristopher @xgreenx @AurelienFT