Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix serailization/deserialization of Policies in compressed transactions to be backward compatible #910

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

AurelienFT
Copy link
Contributor

We changed the compress decompress implementation to not be the default one which would lead to use the default serde implementation for each field. Instead we use a custom implementation that will use the custom serde implementations we have for Policies

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • If performance characteristic of an instruction change, update gas costs as well or make a follow-up PR for that
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

@AurelienFT AurelienFT changed the title Add fix serailization/deserialization to be backward compatible Add fix serailization/deserialization of Policies in compressed transactions to be backward compatible Feb 12, 2025
@AurelienFT AurelienFT requested a review from rymnc February 12, 2025 19:16
Copy link
Member

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can confirm this fix works. :)

@rymnc rymnc merged commit 8a7a59a into release/0.59.2 Feb 13, 2025
40 checks passed
@rymnc rymnc deleted the fix_compressed_policies branch February 13, 2025 07:09
github-merge-queue bot pushed a commit that referenced this pull request Feb 27, 2025
* Update changelog, backckporting 0.59.2 changes as well, i.e. #910

* Bump versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants