Add the remove_recovery_id() to Signature
#909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafal-ch
requested review from
xgreenx,
Dentosal,
MitchTurner and
Voxelot
as code owners
Dentosal
reviewed
Feb 11, 2025
| #[test_case(0x7F => 0x7F)] | ||
| #[test_case(0x80 => 0x00)] | ||
| #[test_case(0xFF => 0x7F)] | ||
| fn removes_recovery_id(s_byte: u8) -> u8 { |
There was a problem hiding this comment.
This test feels like it has wrong layer of abstraction, but I cannot figure out how to test this on a higher level
Dentosal
approved these changes
Feb 11, 2025
rymnc
approved these changes
Feb 11, 2025
1 task
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
remove_recovery_id()function to theSignature. Recovery ID must be removed from the signature in some use cases and this is done manually infuel-core, for example here. Therefore, there will be a follow-up PR for thefuel-corecreated.Closes: #886
Checklist
Before requesting review