Remove unnecessary return values from Storage{Read, Write} methods #907
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reviewing this fix FuelLabs/fuel-core#2673, it became apparent that the return values from StorageRead and StorageWrite traits are not useful and quite misleading. We require the target buffer to be filled completely, which means the caller already knows the number of bytes written after successful invocation.
The PR removes the return values indicating number of bytes written. It's a breaking change, but the fix on caller side is simple and likely affects fuel-core and execution-tracing only.
Checklist
Before requesting review