Splitted big main run function into small #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No changelog only to trigger ci, to remove after |
…ithub.com/FuelLabs/fuel-vm into performance/split-big-function-into-small
|
I think there is a lot some small changes in addition of the splitting maybe worth making multiple smaller PR. |
4 tasks
Voxelot
reviewed
Feb 18, 2025
| interpriter: &mut Interpreter<M, S, Tx, Ecal>, | ||
| ) -> IoResult<ExecuteState, S::DataError> { | ||
| match self { | ||
| Instruction::ADD(op) => op.execute(interpriter), |
There was a problem hiding this comment.
Suggested change
| Instruction::ADD(op) => op.execute(interpriter), | |
| Instruction::ADD(op) => op.execute(interpreter), |
Applied comments from PR
xgreenx
requested review from
xgreenx,
Dentosal and
MitchTurner
as code owners
xgreenx
approved these changes
Feb 18, 2025
Dentosal
approved these changes
Feb 19, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I benchmarked Mira swap - https://app.fuel.network/tx/0xbf476bdaecbc6202ad7a00e7fe379a29661ca8d3f99637095ce18f3e21348f44/advanced.
The execution time on the
masterof thefuel-vm.Execution time on this branch:
Checklist
Before requesting review