-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose leaf_sum
and allow binary MerkleTree
to be built from existing precomputed leafs
#896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from existing precomputed leafs
acerone85
reviewed
Jan 20, 2025
acerone85
previously approved these changes
Jan 20, 2025
xgreenx
previously approved these changes
Jan 27, 2025
rymnc
reviewed
Jan 27, 2025
rymnc
reviewed
Jan 27, 2025
rymnc
reviewed
Jan 27, 2025
rymnc
reviewed
Jan 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments
rymnc
reviewed
Jan 27, 2025
rymnc
approved these changes
Jan 27, 2025
xgreenx
approved these changes
Jan 29, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows us to run
leaf_sum
for each leaf before creating the tree and callnew_from_existing_leafs
using the precomputed leafs.It give the possibility to the caller to optimize the computation of all
leaf_sum
beforehand by parallelising for example.Checklist
Before requesting review