Correctly propagate debugger state while in a contract context #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dentosal
requested review from
xgreenx,
MitchTurner and
Voxelot
as code owners
Dentosal
changed the title
AurelienFT
previously approved these changes
Dec 5, 2024
| @@ -1037,20 +1037,18 @@ where | |||
|
|
|||
| if in_call { | |||
| // Only reverts should terminate execution from a call context | |||
There was a problem hiding this comment.
nit: The comment seems not very descriptive anymore given the changes
xgreenx
previously approved these changes
Dec 6, 2024
AurelienFT
approved these changes
Dec 6, 2024
xgreenx
approved these changes
Dec 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debugger didn't work correctly in contract contexts. This PR changes the debugger pauses to work in contracts as well.
Checklist
Before requesting review