Remove serde feature from the fuel-tx crate
#843
Merged
+221
−154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymnc
approved these changes
Sep 27, 2024
|
No, I haven't tested it, but since we added assert into network ugprader itself, we will see if something is wrong=) |
Dentosal
approved these changes
Sep 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #832
After we introduced the
Upgradetransaction and started to use postcard to encode the consensus parameters, we basically made theserdefeature required.Part of our codebase already derived
serde::Seriliazeandserde::Deserializeregardless of theserdefeature. This PR removes theserdefeature and enables it for thefuel-txcrate by default under theallocfeature.Checklist
Before requesting review