Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback memory changes #837

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Rollback memory changes #837

merged 4 commits into from
Dec 4, 2024

Conversation

xgreenx
Copy link
Collaborator

@xgreenx xgreenx commented Sep 26, 2024

This PR change the function diff that allowed to get changes between two arbitrary VM instances to a rollback_to function that allow to pass from current VM state to a previous one.

This restriction allow us to manage the memory that grows between instances because the current system wasn't working with memory that could grow but only with fixed size memory.

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • If performance characteristic of an instruction change, update gas costs as well or make a follow-up PR for that
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

@AurelienFT AurelienFT marked this pull request as ready for review December 3, 2024 13:50
@AurelienFT AurelienFT requested a review from a team December 3, 2024 13:50
Copy link
Collaborator Author

@xgreenx xgreenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved=)

@xgreenx xgreenx requested a review from AurelienFT December 3, 2024 17:09
Copy link
Member

@Voxelot Voxelot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me a while to wrap my head around all the heap pointer magic, but lgtm after writing a few of my own tests to sanity check.

@xgreenx xgreenx added this pull request to the merge queue Dec 4, 2024
Merged via the queue into master with commit 3e58a6f Dec 4, 2024
40 checks passed
@xgreenx xgreenx deleted the feature/reset-vm branch December 4, 2024 00:41
@xgreenx xgreenx mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants