prevent docker publish job from always running #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Voxelot
force-pushed
the
voxelot/docker-job-fix
branch
from
8a606eb to
22767b7
Compare
adlerjohn
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous PR (#325) I thought using exit 0 in the publish docker image job would cancel it early. Apparently, that just ends the current step and the job keeps going. This changes it back to exit 1 to ensure the job is canceled. This shouldn't cause any further slack issues (apart from potentially a double notification) since those notifications are restricted to master and tags only.
This pr also allows CI to pass if the p2p job fails since there's extensive troubleshooting underway there to resolve flakiness.