backport(gas_price_service): performance improvements to estimate_gas_price #2638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
no changelog added temporarily |
rymnc
force-pushed
the
fix/backport-worst-case-gas-price-fix
branch
from
c78262c to
0e0096a
Compare
rymnc
force-pushed
the
fix/backport-worst-case-gas-price-fix
branch
from
53d36fa to
e2b32e4
Compare
rymnc
force-pushed
the
fix/backport-worst-case-gas-price-fix
branch
2 times, most recently
from
e56b0f3 to
bf38dd7
Compare
rymnc
force-pushed
the
fix/backport-worst-case-gas-price-fix
branch
from
bf38dd7 to
69e4665
Compare
AurelienFT
approved these changes
Jan 28, 2025
AurelienFT
approved these changes
Jan 28, 2025
AurelienFT
added a commit
that referenced
this pull request
Jan 28, 2025
## Version 0.40.4 ### Changed - [2639](#2639): Refactor fetching `latest_height` from `OnChainIterableKeyValueView` to instead use height at the time of its creation. ### Fixed - [2638](#2638): Optimize the `cumulative_percent_change` function used in estimation of gas price, convert multiple async functions to sync.
Merged
5 tasks
rymnc
added a commit
that referenced
this pull request
Feb 11, 2025
…ve_pct_change to master (#2645) ## Linked Issues/PRs <!-- List of related issues/PRs --> - #2638 ## Description <!-- List of detailed changes --> This pull request includes changes to the `fuel-core` service to refactor and improve the handling of gas price calculations. The most important changes involve moving the `cumulative_percentage_change` function to a more appropriate module and updating the relevant imports accordingly. ### Refactoring and code organization: * [`crates/fuel-core/src/service/adapters.rs`](diffhunk://#diff-c710afba67d6633c23d5f7487e423036b27c9f20ec4a8a1541827b366d6e346bL20-R23): Removed the `cumulative_percentage_change` function and updated the import to use the function from the `fuel_core_gas_price_service` module. [[1]](diffhunk://#diff-c710afba67d6633c23d5f7487e423036b27c9f20ec4a8a1541827b366d6e346bL20-R23) [[2]](diffhunk://#diff-c710afba67d6633c23d5f7487e423036b27c9f20ec4a8a1541827b366d6e346bL285-L309) * [`crates/fuel-gas-price-algorithm/src/lib.rs`](diffhunk://#diff-cf07ea6184f936886b3fa85fb3110a28e6d43432b220fdc1165be9bb540e6811R8-R9): Added a public re-export for the `cumulative_percentage_change` function. * [`crates/services/gas_price_service/src/common.rs`](diffhunk://#diff-4af2c7b4b0242528fb33185d685a0c6a8523db872ea96afde6de118f3198bb39R6-R7): Added a public re-export for the `cumulative_percentage_change` function from the `fuel_gas_price_algorithm` module. ### Perf improvements * Same as #2638, but improved `ROUNDING_ERROR_COMPENSATION` calc by comparing asm generated with `-C opt-level=3` previous asm for ROUNDING_ERROR_COMPENSATION: ```asm addsd xmm1, xmm2 movsd xmm0, qword ptr [rip + .LCPI0_5] cmpltsd xmm0, xmm2 andpd xmm1, xmm0 andnpd xmm0, xmm2 orpd xmm0, xmm1 ``` new asm for ROUNDING_ERROR_COMPENSATION: ```asm cmpltsd xmm1, xmm2 movsd xmm0, qword ptr [rip + .LCPI0_5] andpd xmm0, xmm1 addsd xmm0, xmm2 ``` ## Checklist - [x] Breaking changes are clearly marked as such in the PR description and changelog - [x] New behavior is reflected in tests - [x] [The specification](https://github.com/FuelLabs/fuel-specs/) matches the implemented behavior (link update PR if changes are needed) ### Before requesting review - [x] I have reviewed the code myself - [x] I have created follow-up issues caused by this PR and linked them here --------- Co-authored-by: AurelienFT <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
The changes to the
ReadViewwill be made in a follow up PRLinked Issues/PRs
estimateGasPricequeries when txpool has a lot of transactionsDescription
This pull request includes several changes aimed at removing the use of
asyncin various gas price estimation methods and optimizing certain calculations. The main changes involve converting asynchronous functions to synchronous ones and improving the efficiency of a mathematical operation.Conversion from Asynchronous to Synchronous Methods:
crates/fuel-core/src/graphql_api/ports.rs: Theworst_case_gas_pricemethod in theGasPriceEstimatetrait was changed from asynchronous to synchronous.crates/fuel-core/src/service/adapters/fuel_gas_price_provider.rs: Thenext_gas_priceandworst_case_gas_pricemethods in theFuelGasPriceProviderimplementation were changed from asynchronous to synchronous. [1] [2]crates/fuel-core/src/service/adapters/graphql_api.rs: Theworst_case_gas_pricemethod in theStaticGasPriceimplementation was changed from asynchronous to synchronous.crates/services/producer/src/block_producer.rs: Thecalculate_gas_pricemethod was changed from asynchronous to synchronous, and related calls were updated accordingly. [1] [2] [3]Optimization of Mathematical Operations:
crates/fuel-gas-price-algorithm/src/utils.rs: Thecumulative_percentage_changefunction was optimized by replacing the use off64::powfwith a more efficient calculation usingf64::expandf64::ln.Checklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]