Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plex): Improve handling of orphaned API sessions #249

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

FoxxMD
Copy link
Owner

@FoxxMD FoxxMD commented Jan 9, 2025

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Describe your changes

  • Do play cleanup during polling for new plays so that we can discover tracks from abandoned players
  • Fixes missed scrobbles from Plex API when Source stops returning a session due to player queue end
  • Makes grace period for final range larger to compensate for plex api position coarseness (fixed non-100% listened scrobble)

Issue number and link, if applicable

#223

FoxxMD added 2 commits January 9, 2025 18:01
…latforms

* Do play cleanup during polling for new plays so that we can discover tracks from abandoned players
* Fixes missed scrobbles from Plex API when Source stops returning a session due to player queue end #223
* Keep default 3 seconds grace period
* Set grace period for plex to API viewoffset period (rtdrift) of 17 seconds #223
@FoxxMD FoxxMD added bug Something isn't working safe to test trusted to build image labels Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

📦 A new release has been made for this pull request.

To play around with this PR, pull an image:

  • foxxmd/multi-scrobbler:pr-249

Images are available for x86_64 and ARM64.

Latest commit: 30ee000

@FoxxMD FoxxMD merged commit a879b7a into master Jan 14, 2025
7 of 10 checks passed
@FoxxMD FoxxMD deleted the GH-223/plexPlatformCleanup branch January 16, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working safe to test trusted to build image
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant