Add Juju Shortbow and Terminator support to zealot counter #89
Conversation
|
Have you tested this yourself? When I tried it myself it didn't work as expected. Tested with Terminator. |
|
I have tested this with Juju Shortbow and it seemed to work, not sure about Terminator though |
|
I could do more research later tomorrow or at the weekend |
|
I have played a little more, and I noticed that not all kills are counted. My first hypothesis is that my ping could be the issue, as it fluctuates between 150 and goes up to over 200 sometimes. https://1drv.ms/v/c/cecfd75d4641099f/ETwtCjXyFFFFrTY2EMZi5pYBftLetxDgzWTIZ0mdlWcjnA?e=FPd9d5 The code basically calculates whether the time between arrow disappearance and zealot kill is less than 150ms in order for the kill to count. I have even tweaked this value to as high as 500ms, but it doesn't seem to have any effect... @Fix3dll by the way, the I tried to launch on Gradle Java versions 17 and 8, but neither seem to work. Java 17 runClient launch log: https://pastes.dev/1EBLH0eYig |
commit 428f649 Author: Fix3d <[email protected]> Date: Fri Feb 7 18:10:05 2025 +0300 add: show only when holding a mining tool option to Rock Pet Tracker fix: Dolphin Pet Tracker not visible on Edit GUI when show only when holding a fishing rod option is enabled and no rod is held commit 1d302b6 Author: Fix3d <[email protected]> Date: Fri Feb 7 16:21:30 2025 +0300 fix(config): ensure safer file writes with temp file and atomic move commit adef66f Author: Fix3d <[email protected]> Date: Thu Feb 6 21:31:12 2025 +0300 fix: when loadValues() throws Exception and configValues is null or empty, backup corrupted configurations.json file and restore the defaults add: save previous corrupted values in PersistentValues with backupValues() feat(i/o): replace OutputStreamWriter/InputStreamReader with BufferedWriter/BufferedReader for better performance update: enchants.json
|
UPDATE: It seems like when you're enough far away from zealot to prevent nametags from rendering, the counter does not work. Might be because of |
|
@Jakubk15 CONTRIBUTING.md not up to date. You should use loom's configureClientLaunch task. Then just use the Minecraft Launch configuration. I also recommend running the genSourcesWithVineflower task to explore Minecraft classes. |
| @@ -107,7 +107,7 @@ dependencies { | |||
| forge("net.minecraftforge:forge:1.8.9-11.15.1.2318-1.8.9") | |||
| runtimeOnly("me.djtheredstoner:DevAuth-forge-legacy:1.2.1") | |||
|
|
|||
| bundle("org.spongepowered:mixin:0.7.11-SNAPSHOT") { | |||
| bundle("org.spongepowered:mixin:0.8.7-SNAPSHOT") { | |||
There was a problem hiding this comment.
Why did you change mixin version? Version 0.8.x contains some compatibility issues with older Minecraft versions. It causes some conflicts not only with the Minecraft version but also with other mods.
|
At the end of the day, you have to accept that this PR needs more work, as this method will not work reliably with just entering Juju and Terminator's ID. This feature is written according to Explosive Bow's explosive field damage ability. It is not a method that will support all bows. |
|
will reopen/recreate later when i have time to do it, abandoning this for now |
No description provided.