Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: fix blank line in running-config with bmp listener cmd #17278

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

pguibert6WIND
Copy link
Member

An extra blank line is added in show running-config with BMP:

ubuntu2204hwe(config)# router bgp 65500
ubuntu2204hwe(config-router)# bmp targets tgt
ubuntu2204hwe(config-bgp-bmp)# bmp monitor ipv4 unicast pre-policy
ubuntu2204hwe(config-bgp-bmp)# bmp listener 192.0.2.100 port 44
ubuntu2204hwe(config-bgp-bmp)# do show running-config

router bgp 65500
[..]
bmp targets tgt
bmp monitor ipv4 unicast pre-policy
<-- blank line
bmp listener 192.0.2.100 port 44
exit

Remove the blank line.

Fixes: ed18356 ("bgpd/bmp: BMP implementation")

An extra blank line is added in show running-config with BMP:

> ubuntu2204hwe(config)# router bgp 65500
> ubuntu2204hwe(config-router)# bmp targets tgt
> ubuntu2204hwe(config-bgp-bmp)# bmp monitor ipv4 unicast pre-policy
> ubuntu2204hwe(config-bgp-bmp)# bmp listener 192.0.2.100 port 44
> ubuntu2204hwe(config-bgp-bmp)# do show running-config
>
> router bgp 65500
> [..]
>  bmp targets tgt
>   bmp monitor ipv4 unicast pre-policy
>                                       <-- blank line
>   bmp listener 192.0.2.100 port 44
>  exit

Remove the blank line.

Fixes: ed18356 ("bgpd/bmp: BMP implementation")
Signed-off-by: Philippe Guibert <[email protected]>
@ton31337
Copy link
Member

@Mergifyio backport dev/10.2 stable/10.1 stable/10.0 stable/9.1 stable/9.0

Copy link

mergify bot commented Oct 29, 2024

backport dev/10.2 stable/10.1 stable/10.0 stable/9.1 stable/9.0

✅ Backports have been created

@ton31337 ton31337 merged commit e534d9c into FRRouting:master Oct 29, 2024
16 checks passed
ton31337 added a commit that referenced this pull request Oct 29, 2024
bgpd: fix blank line in running-config with bmp listener cmd (backport #17278)
ton31337 added a commit that referenced this pull request Oct 29, 2024
bgpd: fix blank line in running-config with bmp listener cmd (backport #17278)
riw777 added a commit that referenced this pull request Oct 29, 2024
bgpd: fix blank line in running-config with bmp listener cmd (backport #17278)
riw777 added a commit that referenced this pull request Oct 29, 2024
bgpd: fix blank line in running-config with bmp listener cmd (backport #17278)
riw777 added a commit that referenced this pull request Oct 29, 2024
bgpd: fix blank line in running-config with bmp listener cmd (backport #17278)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants