-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bgpd: fix blank line in running-config with bmp listener cmd #17278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An extra blank line is added in show running-config with BMP: > ubuntu2204hwe(config)# router bgp 65500 > ubuntu2204hwe(config-router)# bmp targets tgt > ubuntu2204hwe(config-bgp-bmp)# bmp monitor ipv4 unicast pre-policy > ubuntu2204hwe(config-bgp-bmp)# bmp listener 192.0.2.100 port 44 > ubuntu2204hwe(config-bgp-bmp)# do show running-config > > router bgp 65500 > [..] > bmp targets tgt > bmp monitor ipv4 unicast pre-policy > <-- blank line > bmp listener 192.0.2.100 port 44 > exit Remove the blank line. Fixes: ed18356 ("bgpd/bmp: BMP implementation") Signed-off-by: Philippe Guibert <[email protected]>
@Mergifyio backport dev/10.2 stable/10.1 stable/10.0 stable/9.1 stable/9.0 |
✅ Backports have been created
|
This was referenced Oct 29, 2024
ton31337
added a commit
that referenced
this pull request
Oct 29, 2024
bgpd: fix blank line in running-config with bmp listener cmd (backport #17278)
ton31337
added a commit
that referenced
this pull request
Oct 29, 2024
bgpd: fix blank line in running-config with bmp listener cmd (backport #17278)
riw777
added a commit
that referenced
this pull request
Oct 29, 2024
bgpd: fix blank line in running-config with bmp listener cmd (backport #17278)
riw777
added a commit
that referenced
this pull request
Oct 29, 2024
bgpd: fix blank line in running-config with bmp listener cmd (backport #17278)
riw777
added a commit
that referenced
this pull request
Oct 29, 2024
bgpd: fix blank line in running-config with bmp listener cmd (backport #17278)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An extra blank line is added in show running-config with BMP:
Remove the blank line.
Fixes: ed18356 ("bgpd/bmp: BMP implementation")