-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ospfd:fix syntax of some ospf no commands #17189
ospfd:fix syntax of some ospf no commands #17189
Conversation
e211a67
to
a129dbe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good, but the commit format needs to be fixed ...
found it ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good see one optional comment.
Fix syntax of the following no commands: 1. `no area virtual link A.B.C.D hello-interval <NUM>`, `<NUM>` can be omitted. 2. `no area nssa default-information-originate metric <NUM>`, `<NUM>` can be omitted. 3. `no area nssa range cost <NUM>`, `<NUM>` can be omitted. 4. `no area default cost <NUM>`, `<NUM>` can be omitted. 5. `no ospf write-multiplier <NUM>`, `<NUM>` can be omitted. 6. `no default-information originate metric <NUM>`, `<NUM>` can be omitted. 7. `no distance <NUM>`, `<NUM>` can be omitted. Signed-off-by: Shbinging <[email protected]>
a129dbe
to
03649ff
Compare
Can this commit be merged? @ton31337 |
Fix syntax of some no commands:
no area virtual link A.B.C.D hello-interval <NUM>
,<NUM>
can be omitted.no area nssa default-information-originate metric <NUM>
,<NUM>
can be omitted.no area nssa range cost <NUM>
,<NUM>
can be omitted.no area default cost <NUM>
,<NUM>
can be omitted.no ospf write-multiplier <NUM>
,<NUM>
can be omitted.no default-information originate metric <NUM>
,<NUM>
can be omitted.no distance <NUM>
,<NUM>
can be omitted.