Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ospfd:fix syntax of some ospf no commands #17189

Merged

Conversation

Shbinging
Copy link
Contributor

@Shbinging Shbinging commented Oct 22, 2024

Fix syntax of some no commands:

  1. no area virtual link A.B.C.D hello-interval <NUM>, <NUM> can be omitted.
  2. no area nssa default-information-originate metric <NUM>, <NUM> can be omitted.
  3. no area nssa range cost <NUM>, <NUM> can be omitted.
  4. no area default cost <NUM>, <NUM> can be omitted.
  5. no ospf write-multiplier <NUM>, <NUM> can be omitted.
  6. no default-information originate metric <NUM>, <NUM> can be omitted.
  7. no distance <NUM>, <NUM> can be omitted.

@frrbot frrbot bot added the ospf label Oct 22, 2024
@Shbinging Shbinging force-pushed the fix_some_ospf_unset_commands_syntax branch from e211a67 to a129dbe Compare October 22, 2024 06:57
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, but the commit format needs to be fixed ...

@riw777
Copy link
Member

riw777 commented Oct 22, 2024

code looks good, but the commit format needs to be fixed ...

found it ...

Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Collaborator

@aceelindem aceelindem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good see one optional comment.

Fix syntax of the following no commands:
1. `no area virtual link A.B.C.D hello-interval <NUM>`, `<NUM>` can be omitted.
2. `no area nssa default-information-originate metric <NUM>`, `<NUM>` can be omitted.
3. `no area nssa range cost <NUM>`, `<NUM>` can be omitted.
4. `no area default cost <NUM>`, `<NUM>` can be omitted.
5. `no ospf write-multiplier <NUM>`, `<NUM>` can be omitted.
6. `no default-information originate metric <NUM>`, `<NUM>` can be omitted.
7. `no distance <NUM>`, `<NUM>` can be omitted.

Signed-off-by: Shbinging <[email protected]>
@Shbinging Shbinging force-pushed the fix_some_ospf_unset_commands_syntax branch from a129dbe to 03649ff Compare October 23, 2024 06:02
@Shbinging
Copy link
Contributor Author

Can this commit be merged? @ton31337

@ton31337 ton31337 merged commit cf6a575 into FRRouting:master Oct 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants