Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ospfd: fix some ospf commands #17065

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

Shbinging
Copy link
Contributor

@Shbinging Shbinging commented Oct 11, 2024

This is the fix of #17039

  1. no area range cost NUM, NUM can be omitted
  2. no area shortcut MODE, MODE can be default, that is no area shortcut default

Closes #17039

@ton31337
Copy link
Member

Both commits do not meet contribution guidelines, please follow it.

Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than previous comments, looks okay ...

@Shbinging Shbinging force-pushed the fix_some_ospf_commands branch from cd9b142 to 95186fc Compare October 16, 2024 04:35
@frrbot frrbot bot added the bgp label Oct 16, 2024
@github-actions github-actions bot added size/XXL and removed size/XS labels Oct 16, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Shbinging Shbinging force-pushed the fix_some_ospf_commands branch from cd9b142 to 774788d Compare October 16, 2024 04:39
@ton31337 ton31337 merged commit 5fecb1f into FRRouting:master Oct 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ospf: fix some OSPF commands.
3 participants