Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: Apply and generate route-map commands earlier before any other protocol #17058

Merged

Conversation

ton31337
Copy link
Member

@ton31337 ton31337 commented Oct 10, 2024

Related: #17052

…rotocol

If e.g. BGP neighbor is using a route-map at the boot, that is not yet created,
then the log is spammed with `The route-map 'X' does not exist`.

Processing earlier, should do the trick.

Signed-off-by: Donatas Abraitis <[email protected]>
@donaldsharp
Copy link
Member

I would prefer that we have a general discussion during the weekly meeting about doing a change like this before any decision to put this in is made

@ton31337
Copy link
Member Author

Sure, I wanted to test it first if nothing is broken in CI.

Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777 riw777 merged commit 884e183 into FRRouting:master Oct 15, 2024
14 checks passed
@ton31337 ton31337 deleted the fix/apply_route_maps_earlier branch October 15, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants