fix(tab-nav): emit calciteTabChange event only when selected tab changes
#11812
+7
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anveshmekala
changed the title
calciteTabChange event only when selected tab changes
github-actions
bot
added
the
bug
anveshmekala
added
the
pr ready for visual snapshots
jcfranco
requested changes
Mar 29, 2025
| @@ -37,7 +37,6 @@ describe("calcite-tab-nav", () => { | |||
| const activeEventSpy = await page.spyOnEvent("calciteTabChange"); | |||
| const firstTabTitle = await page.find("calcite-tab-title"); | |||
|
|
|||
| firstTabTitle.setProperty("selected", true); | |||
There was a problem hiding this comment.
We still need this to ensure it doesn’t emit when selecting tab titles programmatically, right?
| @@ -1,6 +1,7 @@ | |||
| export interface TabChangeEventDetail { | |||
| /** The tab ID that just became selected */ | |||
| tab: number | string; | |||
| isUserTriggered?: boolean; | |||
| @@ -47,7 +46,7 @@ describe("calcite-tab-nav", () => { | |||
|
|
|||
| await page.keyboard.press("Enter"); | |||
| await page.waitForChanges(); | |||
| expect(activeEventSpy).toHaveReceivedEventTimes(2); | |||
| expect(activeEventSpy).toHaveReceivedEventTimes(1); | |||
There was a problem hiding this comment.
Can you update the test to cover emitting for both keyboard and mouse interactions? The current version won’t fail if one of the two interactions stops emitting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #9792
Summary
No longer emits
calciteTabChangeevent when selected tab is activated again via mouse or keyboard.