Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(input-message): add component tokens and deprecate --calcite-input-message-spacing-value #11759

Merged
merged 5 commits into from
Mar 27, 2025

Conversation

Elijbet
Copy link
Contributor

@Elijbet Elijbet commented Mar 17, 2025

Related Issue: #7180

Adds the following tokens to input-message component:

--calcite-input-message-icon-color: Specifies the component's icon color.
--calcite-input-message-spacing: Specifies the top margin space above the component.

Deprecates --calcite-input-message-spacing-value: Specifies the top margin space above the component.

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Mar 17, 2025
@Elijbet Elijbet added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Mar 17, 2025
@Elijbet Elijbet added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Mar 18, 2025
Copy link
Contributor

@macandcheese macandcheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the Chromatic, this introduces some spacing changes that should be looked at, for example: https://www.chromatic.com/test?appId=6266d45509d7eb004aa254fb&id=67da0165ade786a6a55044d8

@Elijbet Elijbet added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Mar 19, 2025
@Elijbet
Copy link
Contributor Author

Elijbet commented Mar 19, 2025

Looking at the Chromatic, this introduces some spacing changes that should be looked at, for example: https://www.chromatic.com/test?appId=6266d45509d7eb004aa254fb&id=67da0165ade786a6a55044d8

@macandcheese I think this was fixed here: ab42f8b

Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Should we note the deprecation in the changelog? I don't think it would show up as is since its not in the PR title.

@Elijbet Elijbet changed the title feat(input-message): add component tokens feat(input-message): add component tokens and deprecate --calcite-input-message-spacing-value Mar 27, 2025
@Elijbet Elijbet merged commit 5aa06dd into dev Mar 27, 2025
16 checks passed
@Elijbet Elijbet deleted the elijbet/7180-add-input-message-design-tokens branch March 27, 2025 18:34
@github-actions github-actions bot added this to the 2025-04-29 - Apr Milestone milestone Mar 27, 2025
@jcfranco
Copy link
Member

@Elijbet Can you update the PR description with a commit override to include the deprecation entry (example)?

You can add this to PRs that aren't exclusively deprecation-related (example), but we'll need the override since it was already installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants