-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(input-message): add component tokens and deprecate --calcite-input-message-spacing-value #11759
Conversation
packages/calcite-components/src/components/input-message/input-message.scss
Show resolved
Hide resolved
packages/calcite-components/src/components/input-message/input-message.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the Chromatic, this introduces some spacing changes that should be looked at, for example: https://www.chromatic.com/test?appId=6266d45509d7eb004aa254fb&id=67da0165ade786a6a55044d8
packages/calcite-components/src/components/input-message/input-message.scss
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/input-message/input-message.scss
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/input-message/input-message.scss
Outdated
Show resolved
Hide resolved
@macandcheese I think this was fixed here: ab42f8b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Should we note the deprecation in the changelog? I don't think it would show up as is since its not in the PR title.
Related Issue: #7180
Adds the following tokens to
input-message
component:--calcite-input-message-icon-color
: Specifies the component's icon color.--calcite-input-message-spacing
: Specifies the top margin space above the component.Deprecates
--calcite-input-message-spacing-value
: Specifies the top margin space above the component.