-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: bump style-dictionary
and @tokens-studio/sd-transforms
to latest
#11655
Conversation
This reverts commit caed514.
this is a non-breaking change
I noticed some differences in output files not covered by test snapshots:
Setting this back to draft while I sort that out. |
…nd no longer match the output CSS variable
I addressed the diffs mentioned above. There are some minor differences still, but these include:
I've updated the diff links for a closer check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Code LGTM, nothing jumped out at me besides one nitpick
Related Issue: #11391
Summary
This updates the design tokens build with significant restructuring changes, based on @alisonailea’s astump/style-dictionary-4.x branch. The output remains in sync with production as much as possible to prevent breaking changes.
This is the first step required before addressing additional changes proposed in #11391.
Notable changes
Source restructuring
style-dictionary
+@tokens-studio/sd-transforms
configurationTest and snapshot updates
Transform and token updates
@cspell
dictionary{semantic.color.foreground.1}
source vs type)Test failures
There are a couple of expected spec test failures related to shadows:
--calcite-shadow-0: 0 0 0 0 rgba(var(--calcite-color-neutral-blk-240), 0);
– the color part is invalid syntaxPrep for upcoming changes
tsconfig.json
to support next features used in buildNext steps
Coordinate with @matgalla to update build to accommodate design token updates related to #11391.