Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(block-group, list): Add events for when a user uses the sort dropdown and canPull or canPut returns false #11567

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from
Open

feat(block-group, list): Add events for when a user uses the sort dropdown and canPull or canPut returns false #11567

wants to merge 14 commits into from
+294 −5

Conversation

driskull
Copy link
Member

@driskull driskull commented Feb 15, 2025 •
edited
Loading

Related Issue: #11447

Summary

  • Add events for when a user uses the sort dropdown and canPull or canPut returns false
    • Call canPull and canPut when moving items via the "Move to" menu provided under the drag handle
    • If an item cannot be pulled or put, an event is emitted.
    • Users should handle these events to show a notification of their choice
  • Adds tests

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Feb 15, 2025
@driskull driskull added the skip visual snapshots Pull requests that do not need visual regression testing. label Feb 18, 2025
@driskull driskull changed the title fix(block-group, list): call canPull and canPut when moving items via menu. feat(block-group, list): Add events for when a user uses the sort menu and canPull or canPut returns false Feb 19, 2025
@driskull driskull changed the title feat(block-group, list): Add events for when a user uses the sort menu and canPull or canPut returns false feat(block-group, list): Add events for when a user uses the sort dropdown and canPull or canPut returns false Feb 19, 2025
@driskull driskull marked this pull request as ready for review February 19, 2025 22:57
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Feb 28, 2025
@driskull
Merge branch 'dev' into dris0000/canPull-canPut-keyboard-fix
83f703f 
# Conflicts:
#	packages/calcite-components/src/components/list/list.tsx
@driskull
Copy link
Member Author

@jcfranco @macandcheese this is still awaiting review.

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Mar 28, 2025
@github-actions github-actions bot removed the Stale Issues or pull requests that have not had recent activity. label Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco Awaiting requested review from jcfranco

@macandcheese macandcheese Awaiting requested review from macandcheese

@geospatialem geospatialem Awaiting requested review from geospatialem

At least 1 approving review is required to merge this pull request.

Assignees

@driskull driskull

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. enhancement Issues tied to a new feature or request. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@driskull