-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisit maven shading/release strategy #36
Comments
@magro Can you weigh in? |
Related: #54 |
magro
added a commit
to magro/reflectasm
that referenced
this issue
Jul 16, 2017
Motivation as described in EsotericSoftware#36 Closes EsotericSoftware#36 Closes EsotericSoftware#54
Works for me, thanks a lot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently reflectasm releases a JAR with a transitive dependency on ASM as
and a JAR with ASM bundled and relocated as
This causes some minor headaches such as the shaded JAR sharing a POM with the original JAR so it still has a transitive dependency on ASM which needs to be excluded. But more importantly, using a classifier changes the maven coordinates. This makes it possible to have both the normal and shaded JAR end up in your dependency tree. It also makes it impossible to use Maven's
dependencyManagement
facility to control whether you want the normal or shaded JAR.I think it would be better to distinguish the shaded JAR with a version suffix, something like
1.10.0-shaded
. By using the same maven coordinates, you're guaranteed that you only have either the normal or shaded JAR in your dependency tree, and it's easy to control which one you get through dependency management without needing to resort to exclusions and other hackeryThe text was updated successfully, but these errors were encountered: