Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit maven shading/release strategy #36

Closed
jhaber opened this issue Mar 17, 2015 · 4 comments
Closed

Revisit maven shading/release strategy #36

jhaber opened this issue Mar 17, 2015 · 4 comments

Comments

@jhaber
Copy link

jhaber commented Mar 17, 2015

Currently reflectasm releases a JAR with a transitive dependency on ASM as

<groupId>com.esotericsoftware</groupId>
<artifactId>reflectasm</artifactId>
<version>1.10.0</version>

and a JAR with ASM bundled and relocated as

<groupId>com.esotericsoftware</groupId>
<artifactId>reflectasm</artifactId>
<version>1.10.0</version>
<classifier>shaded</classifier>

This causes some minor headaches such as the shaded JAR sharing a POM with the original JAR so it still has a transitive dependency on ASM which needs to be excluded. But more importantly, using a classifier changes the maven coordinates. This makes it possible to have both the normal and shaded JAR end up in your dependency tree. It also makes it impossible to use Maven's dependencyManagement facility to control whether you want the normal or shaded JAR.

I think it would be better to distinguish the shaded JAR with a version suffix, something like 1.10.0-shaded. By using the same maven coordinates, you're guaranteed that you only have either the normal or shaded JAR in your dependency tree, and it's easy to control which one you get through dependency management without needing to resort to exclusions and other hackery

@NathanSweet
Copy link
Member

@magro Can you weigh in?

@magro
Copy link
Collaborator

magro commented Jul 16, 2017

Related: #54

@NathanSweet
Copy link
Member

@magro Looks like we can close this with #54 and #60.

@jhaber
Copy link
Author

jhaber commented Jun 11, 2018

Works for me, thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants