CodeChecker cmd runs #4468
Open
CodeChecker cmd runs #4468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xb058t
force-pushed
the
cmd-runs
branch
2 times, most recently
from
a83c3a5 to
6dc01b9
Compare
cservakt
requested changes
Mar 26, 2025
Comment on lines
+651
to
+652
| analyzers = info.checkers.keys() | ||
| for analyzer in analyzers: |
There was a problem hiding this comment.
Suggested change
| analyzers = info.checkers.keys() | |
| for analyzer in analyzers: | |
| for analyzer in info.checkers: |
| @@ -682,6 +725,7 @@ def handle_list_runs(args): | |||
| codechecker_version)) | |||
|
|
|||
| print(twodim.to_str(args.output_format, header, rows)) | |||
| return | |||
There was a problem hiding this comment.
The explicit 'return' at the end of the function is unnecessary in Python.
Suggested change
| return |
| print(twodim.to_str(args.output_format, header, rows)) | ||
| else: | ||
| LOG.error("Unsupported output format: %s", args.output_format) | ||
| return |
There was a problem hiding this comment.
Adding return here is totally unnecessary.
Suggested change
| return |
Comment on lines
+643
to
+682
| if hasattr(args, 'enabled_checkers') and args.enabled_checkers: | ||
| enabled_checkers: Dict[str, List[str]] = {} | ||
| for run in runs: | ||
| info_list: List[ttypes.AnalysisInfo] = client.getAnalysisInfo( | ||
| ttypes.AnalysisInfoFilter(runId=run.runId), | ||
| constants.MAX_QUERY_SIZE, | ||
| 0) | ||
| for info in info_list: | ||
| analyzers = info.checkers.keys() | ||
| for analyzer in analyzers: | ||
| if analyzer not in enabled_checkers: | ||
| enabled_checkers[analyzer] = [] | ||
|
|
||
| checkers = info.checkers.get(analyzer, {}) | ||
| for checker in checkers: | ||
| if checkers[checker].enabled: | ||
| enabled_checkers[analyzer].append(checker) | ||
|
|
||
| if args.output_format == 'plaintext': | ||
| for analyzer, checkers in enabled_checkers.items(): | ||
| print(analyzer + ":") | ||
| for checker in checkers: | ||
| print(" " + checker) | ||
| elif args.output_format == 'csv': | ||
| separator = ';' | ||
| print("Analyzer" + separator + "Checker") | ||
| for analyzer, checkers in enabled_checkers.items(): | ||
| for checker in checkers: | ||
| print(analyzer + separator + checker) | ||
| elif args.output_format == 'json': | ||
| print(json.dumps(enabled_checkers, indent=4)) | ||
| elif args.output_format == 'table': | ||
| header = ['Analyzer', 'Checker'] | ||
| rows = [ | ||
| (analyzer, checker) | ||
| for analyzer, checkers in enabled_checkers.items() | ||
| for checker in checkers] | ||
| print(twodim.to_str(args.output_format, header, rows)) | ||
| else: | ||
| LOG.error("Unsupported output format: %s", args.output_format) |
There was a problem hiding this comment.
Instead of introducing a separate if block for enabled_checkers handling, consider integrating it into the existing structure, similar to how 'details' is handled. This avoids redundant checks on args.output_format.
Additionally, rather than using direct print statements for plaintext and CSV formats, it would be better to use twodim.to_str() for consistency with the existing output formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the feature requested in issue #4355