Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: unused-workspace-dependencies false positives for any git dependency #680

Closed
jaskij opened this issue Jul 26, 2024 · 7 comments · Fixed by #681
Closed

Bug: unused-workspace-dependencies false positives for any git dependency #680

jaskij opened this issue Jul 26, 2024 · 7 comments · Fixed by #681
Labels
bug Something isn't working

Comments

@jaskij
Copy link

jaskij commented Jul 26, 2024

Describe the bug

For all my git dependencies, even if they are used under dependencies in multiple crates in the workspace, unused-workspace-dependencies

To reproduce

  1. workspace
  2. git dependency in the workspace
  3. a number of crates in the workspace
  4. those crates inheriting the workspace dependency
  5. cargo deny check

cargo-deny version

0.15.0

What OS were you running cargo-deny on?

Linux

Additional context

No response

@Jake-Shadle
Copy link
Member

I'll need a repro, git dependencies are tested for, but maybe there is something I missed with source matching.

@jaskij
Copy link
Author

jaskij commented Jul 26, 2024

@jaskij
Copy link
Author

jaskij commented Jul 26, 2024

Actually using the dependency in the crate shouldn't matter, right? As long as it's present in the workspace and inherited by the crate.

@Jake-Shadle
Copy link
Member

cargo-deny never looks at source code.

@jaskij
Copy link
Author

jaskij commented Jul 26, 2024

One thing I have noticed, which may or may not matter: some workspaces, but neither mine nor serde's, have a top-level package.

@Jake-Shadle
Copy link
Member

Thanks for the report and repro, fixed in 0.15.1

@jaskij
Copy link
Author

jaskij commented Jul 26, 2024

Thanks for the quick fix.

Also, since I don't think I said this earlier, thanks for the feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants