Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maniac: Implement Loop and Break Loop enhancements #2649

Merged
merged 4 commits into from
Feb 17, 2022

Conversation

Ghabry
Copy link
Member

@Ghabry Ghabry commented Sep 13, 2021

This will be the final Maniac Patch-patch for 0.7. I still have ControlVarArray and some stuff for ControlVariable to offer but this stuff will be half-broken because the variable range is wrong (Maniac has 32bit range without overflow), so makes no sense to add this when calculation will get stuck at 9999999.


I still have to carefully recheck all the loop commands. There could be off-by-1 errors I missed :)

@Ghabry Ghabry added this to the 0.7.0 milestone Sep 13, 2021
@Ghabry Ghabry marked this pull request as ready for review October 17, 2021 00:08
@Ghabry Ghabry removed the Has PR Dependencies This PR depends on another PR label Oct 17, 2021
@fdelapena fdelapena requested a review from carstene1ns October 21, 2021 00:24
@Ghabry
Copy link
Member Author

Ghabry commented Oct 21, 2021

I will do a final savegame comparison here jsut to ensure that I have no off-by-one errors.

@Ghabry
Copy link
Member Author

Ghabry commented Oct 22, 2021

Is maybe better to move this to 0.7.1 before I break more in the last minute 😅

@Ghabry Ghabry modified the milestones: 0.7.0, 0.7.1 Oct 22, 2021
@Ghabry
Copy link
Member Author

Ghabry commented Nov 1, 2021

Good that this was delayed. Found two save incompatibilites vs. Maniac Patch when using "X Times". Is correct now.

@Ghabry
Copy link
Member Author

Ghabry commented Nov 14, 2021

This PR is not urgent so I give till end of month for more reviews before merge :)

Unfortunately hard to test on specific games because they usually use more than just the loops of maniac :/

@Ghabry
Copy link
Member Author

Ghabry commented Jan 14, 2022

I'm slowly considering to simply call the next release 0.7.1 instead of 0.7.0.1. There are already lots of enhancements again and the additions by rueter and BlisterB (SAF) are almost merge ready (a matter of a few weeks).

This would also unblock this PR and allow merging it.

@Ghabry
Copy link
Member Author

Ghabry commented Feb 17, 2022

This one is also rdy for merge

@fdelapena fdelapena merged commit ecf1136 into EasyRPG:master Feb 17, 2022
@Ghabry Ghabry deleted the maniac-loop branch February 22, 2022 13:41
@Ghabry Ghabry mentioned this pull request Mar 17, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants