-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maniac: Implement Loop and Break Loop enhancements #2649
Conversation
I will do a final savegame comparison here jsut to ensure that I have no off-by-one errors. |
Is maybe better to move this to 0.7.1 before I break more in the last minute 😅 |
Good that this was delayed. Found two save incompatibilites vs. Maniac Patch when using "X Times". Is correct now. |
This PR is not urgent so I give till end of month for more reviews before merge :) Unfortunately hard to test on specific games because they usually use more than just the loops of maniac :/ |
I'm slowly considering to simply call the next release 0.7.1 instead of 0.7.0.1. There are already lots of enhancements again and the additions by rueter and BlisterB (SAF) are almost merge ready (a matter of a few weeks). This would also unblock this PR and allow merging it. |
This one is also rdy for merge |
This will be the final Maniac Patch-patch for 0.7. I still have ControlVarArray and some stuff for ControlVariable to offer but this stuff will be half-broken because the variable range is wrong (Maniac has 32bit range without overflow), so makes no sense to add this when calculation will get stuck at 9999999.
I still have to carefully recheck all the loop commands. There could be off-by-1 errors I missed :)