Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Angular 13 #245

Closed
1 of 4 tasks
umairhm opened this issue Nov 6, 2021 · 7 comments · Fixed by #246
Closed
1 of 4 tasks

Support for Angular 13 #245

umairhm opened this issue Nov 6, 2021 · 7 comments · Fixed by #246

Comments

@umairhm
Copy link
Contributor

umairhm commented Nov 6, 2021

Summary

I'm submitting a:

  • bug report
  • feature request
  • question / support request
  • other

Description

Angular 13 has been released on November 03, 2021. This is to start the discussion on upgrading ng-recaptcha to support Angular 13.

Lib versions:

  • ng-recaptcha: 8.1.0
  • Angular: 13.0.0
  • Typescript (tsc --version): 4.4.4
@Solat-Ali
Copy link

+1

umairhm added a commit to umairhm/ng-recaptcha that referenced this issue Nov 8, 2021
@EvanSevy
Copy link

Is there an ETA on when we might get this support for ng13?

@umairhm
Copy link
Contributor Author

umairhm commented Nov 13, 2021

Is there an ETA on when we might get this support for ng13?

The PR is ready for review and further steps. I hope it gets merged sooner than later.

@DethAriel
Copy link
Owner

DethAriel commented Nov 14, 2021 via email

umairhm added a commit to umairhm/ng-recaptcha that referenced this issue Nov 16, 2021
DethAriel pushed a commit that referenced this issue Nov 16, 2021
* feat(package): upgrade to angular 13

closes #245
DethAriel pushed a commit that referenced this issue Nov 16, 2021
@Christian-Devs
Copy link

Hi.
I am currently trying to use this package but it is giving me the following error when running ng serve:
Error: node_modules/ng-recaptcha/lib/recaptcha-value-accessor.directive.d.ts:17:18 - error TS2314: Generic type 'ɵɵDirectiveDeclaration' requires 6 type argument(s).

17 static ɵdir: i0.ɵɵDirectiveDeclaration<RecaptchaValueAccessorDirective, "re-captcha[formControlName],re-captcha[formControl],re-captcha[ngModel]", never, {}, {}, never, never, false>;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Error: node_modules/ng-recaptcha/lib/recaptcha.component.d.ts:59:18 - error TS2314: Generic type 'ɵɵComponentDeclaration' requires 7 type argument(s).

59 static ɵcmp: i0.ɵɵComponentDeclaration<RecaptchaComponent, "re-captcha", ["reCaptcha"], { "id": "id"; "siteKey": "siteKey"; "theme": "theme"; "type": "type"; "size": "size"; "tabIndex": "tabIndex"; "badge": "badge"; "errorMode": "errorMode"; }, { "resolved": "resolved"; "error": "error"; }, never, never, false>;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~[0m

How do I resolve this issue

@DethAriel
Copy link
Owner

@Christian-Devs please consult the versions compatibility table in the README. If the problem persists, please open a new issue, following the issue template

@Christian-Devs
Copy link

@Christian-Devs please consult the versions compatibility table in the README. If the problem persists, please open a new issue, following the issue template

Hi DethAriel.
Thank you, I downgraded to v9.0.0 and it worked fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants