Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integration test #2122

Open
visr opened this issue Mar 3, 2025 · 0 comments
Open

Fix integration test #2122

visr opened this issue Mar 3, 2025 · 0 comments
Labels
CI/CD Continuous Integration/Continuous deployment test Relates to unit testing

Comments

@visr
Copy link
Member

visr commented Mar 3, 2025

The results have changed too much, and the speed as well. Running again to check if it was noise.

https://dpcbuild.deltares.nl/buildConfiguration/Ribasim_IntegrationTest_Linux
@github-project-automation github-project-automation bot moved this to To do in Ribasim Mar 3, 2025
@visr visr added CI/CD Continuous Integration/Continuous deployment test Relates to unit testing labels Mar 3, 2025
This was referenced Mar 3, 2025
Closed
Merged
visr added a commit that referenced this issue Mar 3, 2025
@visr
Revert "Make min_upstream_level and max_downstream_level controllable… (
c766935 
#2125)

… (#2088)"

This reverts commit c87c70f.

This caused a considerable slowdown of the HWS model. I think it is just
because parameter updates are slow, and this does 3 instead of 1.

Related to #2122
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI/CD Continuous Integration/Continuous deployment test Relates to unit testing
Projects
Ribasim
Status: To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@visr