Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Basin Parameter (constructor) #1905

Closed
evetion opened this issue Oct 16, 2024 · 2 comments · Fixed by #1929
Closed

Refactor Basin Parameter (constructor) #1905

evetion opened this issue Oct 16, 2024 · 2 comments · Fixed by #1929

Comments

@evetion
Copy link
Member

evetion commented Oct 16, 2024

Also, this basin Basin constructor is getting rather monstrous, could be divided into several parts. That is out of the scope of this PR though, so could be worth a new issue.

Originally posted by @SouthEndMusic in #1849 (comment)
@github-project-automation github-project-automation bot moved this to To do in Ribasim Oct 16, 2024
@evetion
Copy link
Member Author

evetion commented Oct 16, 2024

Maybe it would be a simple development quality of life improvement of we make a simple Base.show method for Parameters.

@SouthEndMusic
Copy link
Collaborator

My changes here could serve as an inspiration. I split out a coherent subset of the fields as a substruct. This one doesn't need any code in the Basin constructor, but other substructs could get their own constructor.

@SouthEndMusic SouthEndMusic mentioned this issue Nov 7, 2024
Merged
SouthEndMusic added a commit that referenced this issue Nov 25, 2024
@SouthEndMusic @evetion
Refactor of concentration code (#1929)
4e9f479 
Fixes #1905

---------

Co-authored-by: Maarten Pronk <[email protected]>
@github-project-automation github-project-automation bot moved this from To do to ✅ Done in Ribasim Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Ribasim
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor of concentration code Deltares/Ribasim
2 participants
@evetion @SouthEndMusic