-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UserDemand: make demand and allocated Matrix{Float64} #1277
Comments
For BMI it seems we should offer one dimensional arrays. I only started doing that when someone pointed me to the best practices in csdms/bmi-example-julia#5. Still I don't get the row/column-major indexing reason, since flattening it does not resolve that. However, just like the linked PR we can use a Matrix internally, and only towards the BMI offer it in 1D, that |
I guess you're automatically forced to think about row/column-major array on the receiving part if it's a flat array. We can reconstruct it into a 2D array in imod_coupler anyway using |
These fields are currently initialized as a single long vector and a vector of vector.
Having them as matrix would be nicer.
This should work fine with the BMI as well.
The text was updated successfully, but these errors were encountered: