Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runoff to Basin #1071

Open
Huite opened this issue Feb 5, 2024 · 2 comments
Open

Add runoff to Basin #1071

Huite opened this issue Feb 5, 2024 · 2 comments
Labels
core Issues related to the computational core in Julia coupling Coupling to other models wflow issues related to coupling wflow

Comments

@Huite
Copy link
Contributor

Huite commented Feb 5, 2024

The current Basin definition:

struct Basin{T, C} <: AbstractParameterNode
    node_id::Indices{NodeID}
    precipitation::Vector{Float64}
    potential_evaporation::Vector{Float64}
    drainage::Vector{Float64}
    infiltration::Vector{Float64}
    # cache this to avoid recomputation
    current_level::T
    current_area::T
    ...

does not have a vector for the urban runoff values.

Secondly, should it maybe just be runoff? Not clear whether we need the distinction.

For the coupling, MetaSWAP will just return runoff. Urban areas are separated in terms of their SVAT unit, but it's the same water balance term.

@github-project-automation github-project-automation bot moved this to To do in Ribasim Feb 5, 2024
@Huite Huite added the bug label Feb 5, 2024
@Huite Huite changed the title Urban runoff is not used simulation? And what about non-urban runoff? Urban runoff is not used by simulation? And what about non-urban runoff? Feb 5, 2024
@gijsber
Copy link
Contributor

gijsber commented Feb 5, 2024

distinction of urban runoff would be a good nice-to-have as it allows future distinction at the WWTP between dry-weather and wet-weather waste loads. If it becomes hard to make this seperation between urban and non-urban runoff, we should do it now, else we can postpone.

@SnippenE SnippenE added documentation Improvements or additions to documentation metaswap issues related to coupling metaswap labels Feb 22, 2024
@SnippenE SnippenE moved this from To do to What's next in Ribasim Feb 22, 2024
@SnippenE SnippenE added enhancement and removed documentation Improvements or additions to documentation bug labels Feb 22, 2024
@visr
Copy link
Member

visr commented Feb 22, 2024

To resolve this, we will rename urban_runoff to runoff and implement this similar to the way we implement drainage. Also needs to be integrated and added to basin.arrow like the other Basin vertical fluxes. Also needs doc updates.

@gijsber gijsber changed the title Urban runoff is not used by simulation? And what about non-urban runoff? Update Urban runoff to runoff Feb 22, 2024
@SnippenE SnippenE added the coupling Coupling to other models label Apr 18, 2024
@Jingru923 Jingru923 added core Issues related to the computational core in Julia and removed metaswap issues related to coupling metaswap labels May 2, 2024
@Jingru923 Jingru923 changed the title Update Urban runoff to runoff Incorporate Urban runoff in core May 2, 2024
@Jingru923 Jingru923 added the wflow issues related to coupling wflow label May 2, 2024
@Jingru923 Jingru923 moved this from What's next to To do in Ribasim May 2, 2024
@visr visr added the v1.0 label Jul 4, 2024
@visr visr changed the title Incorporate Urban runoff in core Add runoff to Basin Jul 4, 2024
@SnippenE SnippenE removed the v1.0 label Jul 15, 2024
Jingru923 pushed a commit that referenced this issue Jul 16, 2024
This takes care of the removing `urban_runoff` part of #1071.
Technically breaking if people had this unused column in their Basin
tables.
@visr visr removed the enhancement label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues related to the computational core in Julia coupling Coupling to other models wflow issues related to coupling wflow
Projects
Status: To do
Development

No branches or pull requests

5 participants