Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move arcface_loss into loss_utils.py. #37

Merged
merged 1 commit into from
Aug 20, 2019
Merged

Move arcface_loss into loss_utils.py. #37

merged 1 commit into from
Aug 20, 2019

Conversation

barius
Copy link
Collaborator

@barius barius commented Aug 19, 2019

Fix #30

Pull Request Summary

Moving def arcface_loss to utils and support weights from outer and create inner.
And also add unit test.

Test Plan

python delta/utils/loss/loss_utils_test.py

Reviewers

@zh794390558

zh794390558
zh794390558 approved these changes Aug 20, 2019
View reviewed changes
Copy link
Collaborator

@zh794390558 zh794390558 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zh794390558 zh794390558 merged commit e417491 into master Aug 20, 2019
@zh794390558 zh794390558 deleted the move_arcface branch August 20, 2019 07:02
@hankun11 hankun11 assigned hankun11 and unassigned hankun11 Aug 22, 2019
@hankun11 hankun11 mentioned this pull request Aug 22, 2019
Closed
@GaryGao99
Copy link
Collaborator

[ OK ] LossUtilTest.test_arcface_loss
I ran python delta/utils/loss/loss_utils_test.py without any error， please check your environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zh794390558 zh794390558 zh794390558 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

move arcface_loss to loss_utils
4 participants
@barius @GaryGao99 @zh794390558 @hankun11