Add aave v2, v3 helper and Avalon Finance adapter #2713
+445
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The avalon.ts adapter exports: |
|
The avalon.ts adapter exports: |
|
The avalon.ts adapter exports: |
g1nt0ki
reviewed
Mar 26, 2025
| params: [event.reserve], | ||
| skipCache: true, | ||
| permitFailure: false, | ||
| block: event.blockNumber - 1, |
There was a problem hiding this comment.
this line is why the block parameter you set here are ignored: https://github.com/DefiLlama/defillama-sdk/blob/master/src/ChainApi.ts#L48
so, instead of options.api, you need to use the vannila sdk.api2.call like here:
https://github.com/DefiLlama/DefiLlama-Adapters/blob/main/projects/contango/index.js#L21
There was a problem hiding this comment.
but, approx how many of these events are emitted per day? if it is a lot, one rpc call per event is not exactly scalable
g1nt0ki
reviewed
Mar 26, 2025
helpers/aave/index.ts
Outdated
| // get reserves configs, mainly reserveFactor values | ||
| const reserveConfigs = await options.api.multiCall({ | ||
| abi: AaveAbis.getReserveConfiguration, | ||
| calls: reservesList.map( |
There was a problem hiding this comment.
no need for the map here, you can move the target to the top level and do calls: reservesList,
g1nt0ki
reviewed
Mar 26, 2025
helpers/aave/index.ts
Outdated
| const totalDailySupplySideRevenue = options.createBalances() | ||
|
|
||
| for (const pool of pools) { | ||
| const { dailyFees, dailyRevenue } = await getPoolFees(pool, options) |
There was a problem hiding this comment.
why not pass dailyFees & dailyRevenue as third arg, this way, you dont have add everything up later
g1nt0ki
reviewed
Mar 26, 2025
helpers/aave/index.ts
Outdated
| totalDailyHoldersRevenue.addBalances(dailyRevenue) | ||
|
|
||
| Object.entries(dailyRevenue.getBalances()).forEach(([token, balance]) => { | ||
| totalDailySupplySideRevenue.addTokenVannila(token, Number(balance) * -1) |
There was a problem hiding this comment.
you can simplify this by cloning the dailyFees object (.clone() ) and then subtracting daily revenue object (https://github.com/DefiLlama/defillama-sdk/blob/master/src/Balances.ts#L153)
|
The avalon.ts adapter exports: |
|
The avalon.ts adapter exports: |
g1nt0ki
reviewed
Mar 27, 2025
| @@ -76,7 +68,7 @@ async function getPoolFees(pool: AaveLendingPoolConfig, options: FetchOptions): | |||
| .flat() | |||
|
|
|||
| for (const event of events) { | |||
| const reserveData = await options.api.call({ | |||
| const reserveData = await sdk.api2.abi.call({ | |||
There was a problem hiding this comment.
need to pass chain parameter here, else it will run against ethereum (the default chain)
|
The avalon.ts adapter exports: |
|
The avalon.ts adapter exports: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request support the Aave fees and revenue helper. It supports version 2 and version 3. Forks can use this helper with given configs.
This pull request also contains a case study of Avalon Finance is using Aave helper.