Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aletheia Integration - Long Term Branch #846

Draft
wants to merge 63 commits into
base: dev
Choose a base branch
from
Draft

Conversation

TilakMaddy
Copy link
Contributor

@TilakMaddy TilakMaddy commented Mar 16, 2025

Perf gains !! 💪

  • Support symlinks
  • Soldeer support (right now, aderyn crashes when soldeer is found)
  • Fixed version compilation
  • EVM version detection
  • Speed improvements? ..you bet.

Caveat:
While we manage to detect the EVM version and solc version, we don't do nothing with it yet. But this PR _gives the ability to do so, in the future

Misc:

No longer need to cargo publish these 2 crates -
cyfrin-foundry-compilers = "0.3.20-aderyn"
cyfrin-foundry-config = "0.2.1"

Aletheia is all in one.

One more cool benefit is that we only expose required stuff from aletheia so auto-complete feels better

TODO

  • Find out why temple gold report is different and fix it.

    • I spent a whole day and not even close to knowing how why i get different ASTs (same number of nodes though) resulting in diff report. 😭 @alexroan can you help ?

    • I have verified

      • same compiler versions (current dev <> aletheia)
      • same set of files (current dev <> aletheia)
      • same error definitions ids (current dev <> aletheia)
      • DIFFERENT referenced_declaration (current dev <> aletheia) ...which causes false positives to show up
  • Remove dev-dependencies on

    • cyfrin-foundry-compilers = "0.3.20-aderyn"
    • cyfrin-foundry-config = "0.2.1"

    (Basically have to re-write the testing arch using aletheia)

@TilakMaddy TilakMaddy marked this pull request as ready for review March 16, 2025 18:54
@TilakMaddy TilakMaddy requested a review from alexroan as a code owner March 16, 2025 18:54
@TilakMaddy
Copy link
Contributor Author

TilakMaddy commented Mar 16, 2025

@alexroan Please 🙏 try this out locally on some of your repos and get back to me...

LMK if you notice a considerable performance gain

@TilakMaddy TilakMaddy changed the title Integrate/aletheia Integrate/aletheia [Don't merge YET] Mar 17, 2025
@TilakMaddy TilakMaddy marked this pull request as draft March 17, 2025 04:48
@TilakMaddy TilakMaddy changed the title Integrate/aletheia [Don't merge YET] Integrate/aletheia Mar 17, 2025
@TilakMaddy

This comment was marked as duplicate.

@TilakMaddy TilakMaddy changed the title Integrate/aletheia Aletheia Integration - Long Term Branch Mar 18, 2025
@TilakMaddy
Copy link
Contributor Author

Probably our assumptions on how source maps work is incorrect.... :(

@TilakMaddy
Copy link
Contributor Author

TilakMaddy commented Mar 19, 2025

@alexroan Can you please run cargo build (so you build up cache) followed by cli/reportgen.sh in this branch. Then tell me if you are able to generate the same report for templegold as dev branch ?

Also you can try cargo prep --tg

that works too 😅 !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant