-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aletheia Integration - Long Term Branch #846
base: dev
Are you sure you want to change the base?
Conversation
@alexroan Please 🙏 try this out locally on some of your repos and get back to me... LMK if you notice a considerable performance gain |
This comment was marked as duplicate.
This comment was marked as duplicate.
Probably our assumptions on how source maps work is incorrect.... :( |
@alexroan Can you please run Also you can try that works too 😅 !!! |
Perf gains !! 💪
Caveat:
While we manage to detect the EVM version and solc version, we don't do nothing with it yet. But this PR _gives the ability to do so, in the future
Misc:
No longer need to
cargo publish
these 2 crates -cyfrin-foundry-compilers = "0.3.20-aderyn"
cyfrin-foundry-config = "0.2.1"
Aletheia is all in one.
One more cool benefit is that we only expose required stuff from aletheia so auto-complete feels better
TODO
Find out why temple gold report is different and fix it.
I spent a whole day and not even close to knowing how why i get different ASTs (same number of nodes though) resulting in diff report. 😭 @alexroan can you help ?
I have verified
Remove dev-dependencies on
(Basically have to re-write the testing arch using aletheia)