-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EP-2564 - minimize EFT agreement #1167
base: master
Are you sure you want to change the base?
Conversation
356f2d5
to
35445c2
Compare
I see potential for needing to make the checkbox text no longer all caps as well as maybe changing the reference within the agreement to the checkbox while UAT is happening, we will see what the stakeholders want. I could also see potential for needing to move the agreement below the checkbox. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could also see potential for needing to move the agreement below the checkbox.
I also expected the agreement to appear below the checkbox, but we can see what stakeholders think.
Great work on this!
src/common/components/paymentMethods/bankAccountForm/bankAccountForm.tpl.html
Outdated
Show resolved
Hide resolved
src/common/components/paymentMethods/bankAccountForm/bankAccountForm.component.js
Show resolved
Hide resolved
35445c2
to
61ae0e7
Compare
c85137e
to
32945f0
Compare
Jira
This PR puts the EFT agreement behind a link to reduce friction and vertical space on the bank account creation form.