Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#501 can't be rebased -- recreating the PR on top of master.
Motivation; enable other gnark objects (like
groth16.ProvingKey
) to be written and read very fast (though not portable). Limit code duplication between curves, fields, proof systems, etc.utils/unsafe
withWriteSlice[S ~[]E, E any](w io.Writer, s S) error
... ;kzg.UnsafeToBytes(...) []byte
is nowWriteDump(w io.Writer) error
🔥 Benchmarks for kzg SRS dump 🔥 --> (I mean using
unsafe
is a cheat, we just benchmark the non-unsafe method + real IO)