-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: init e2e-fixture-base #114
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View your CI Pipeline Execution ↗ for commit 78a50a6.
☁️ Nx Cloud last updated this comment at |
# Conflicts: # pnpm-lock.yaml
BioPhoton
commented
Mar 5, 2025
__dirname, | ||
`../../../e2e/__test__/${targetProjectName}` | ||
); | ||
export async function setupE2eApp({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function maintains the logic that runs pre-e2e and is responsible to setup a project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🦾 CI/CD
Continuous integration and deployment
📖 documentation
🧪 testing
Tests, mocks and configuration
🛠️ tooling
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precondition:
#104
related to #99
The Idea
add targets to e2e projects
This PR includes:
e2e-fixtures-base
*-e2e
projectsrsbuild-csr-css
rsbuild-csr-scss
rsbuild-ssr-css
rsbuild-ssr-scss
Note:
I kept some fixtures as there are currently no e2e tests implemented.
rspack-csr-css
rspack-ssr-css
New Tree:
Current State:
It seems like the idea is not working. Locally it only works if we run sequentially and in CI it fails