Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: init e2e-fixture-base #114

Closed
wants to merge 14 commits into from
Closed

ci: init e2e-fixture-base #114

wants to merge 14 commits into from

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Feb 26, 2025

Precondition:
#104

related to #99

The Idea

add targets to e2e projects

{
// ...
  "e2e": {
    "dependsOn": ["pre-e2e"]
  }
  "pre-e2e": {
    "command": "node setup.js" // this dynamically creates a project that can be reference in the `playwrite.config.js`
  }
}

This PR includes:

  • introduce e2e-fixtures-base
  • introduce setup script - 👀 interesting change
  • add test fixtures and use setup script for all *-e2e projects
  • remove fixtures
    • rsbuild-csr-css
    • rsbuild-csr-scss
    • rsbuild-ssr-css
    • rsbuild-ssr-scss

Note:

  • I kept some fixtures as there are currently no e2e tests implemented.

    • rspack-csr-css
    • rspack-ssr-css

    New Tree:

root
┇
┣━ 📂 e2e 
┇  ┣━ 📂 fixtures
   ┃  ┗━ 📂 e2e-fixture-base    
   ┣━ 📂 rsbuild-csr-css-e2e 
   ┃  ┗━ 📂 mock/fixtures/csr-css # css components and files here
   ┣━ 📂 rsbuild-csr-scss-e2e 
   ┃  ┗━ 📂 mock/fixtures/csr-scss # scss components and files here
   ┣━ 📂 rsbuild-ssr-css-e2e  
   ┃  ┗━ 📂 mock/fixtures/csr-less # css components and files here
   ┇

Current State:

It seems like the idea is not working. Locally it only works if we run sequentially and in CI it fails

Copy link

nx-cloud bot commented Feb 26, 2025

View your CI Pipeline Execution ↗ for commit 78a50a6.

Command Status Duration Result
nx affected -t e2e --no-parallel ❌ Failed 1m 24s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-03 23:14:38 UTC

@BioPhoton BioPhoton mentioned this pull request Feb 26, 2025
7 tasks
@BioPhoton BioPhoton self-assigned this Feb 26, 2025
@github-actions github-actions bot added the 🦾 CI/CD Continuous integration and deployment label Mar 3, 2025
__dirname,
`../../../e2e/__test__/${targetProjectName}`
);
export async function setupE2eApp({
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function maintains the logic that runs pre-e2e and is responsible to setup a project.

@Coly010 Coly010 closed this Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦾 CI/CD Continuous integration and deployment 📖 documentation 🧪 testing Tests, mocks and configuration 🛠️ tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants