Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve "Initialise offset in pack_coupling_array" #41

Merged
merged 1 commit into from
Oct 28, 2019

Conversation

penguian
Copy link
Contributor

Resolves #40.

What is the best way to test such a change? I would suggest a unit test, but as far as I can tell, this project does not have a unit testing framework, regression testing, or continuous integration. In the absence of unit tests, I have tested using https://github.com/COSIMA/access-om2/blob/master/test/test_bit_reproducibility.py Am I missing something?

Also, should I create a separate GitHub account for my NCI work, using [email protected] as my email address?

@russfiedler russfiedler self-assigned this Oct 28, 2019
@russfiedler
Copy link
Contributor

This is a pretty bad bug to let through. I'm not sure how the code ever worked as ifort is generally pretty good at "initialising" with rubbish.We should be compiling and testing with ifort -check all ... or at least enable the uninitialised variable, bounds checking and uninitialised pointers. Arrays are tougher but can be done.. gfortran is pretty crappy at detecting uninitialised variables.

@russfiedler russfiedler merged commit dd02b01 into COSIMA:master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initialise offset in pack_coupling_array
2 participants