Fix error response

[bennavapbc]

🎫 Ticket

https://jira.cms.gov/browse/AB2D-6579

🛠 Changes

Fix error handling related to the download API so that error messages are displayed to the user. Currently, a blank response is returned to the user.

ℹ️ Context

Currently, the download API fails to return error message to the user. The server sends a blank response and HTTP 500.

For reference, the status API returns a helpful error message if e.g. a job is not found:

If an exception is thrown from the status API, the ErrorHandler catches the exception and returns an error response as expected.

If an exception is thrown from the download API, the ErrorHandler does not catch the exception. The exception bubbles up until a ServletException is thrown.

• The reason for this is not clear. The download and status APIs have similar configuration. The only difference is the download API method accepts a HttpServletResponse response which is written to directly. Spring might exclude methods like this from error handling?

🧪 Validation

Deployed to IMPL and verified the following download scenarios return helpful error messages:

• Valid job ID but non-existent file
• Non-existent job ID
• File downloaded the max number of times

[bennavapbc]

Instead of merging to main, this code is now part of PR #1440