meshgen optionality #266
Merged
meshgen optionality #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h improvements even when quality is decreasing or large number of nodes eliminated, which sometimes is necessary to force the advancement in mesh quality. 2) adding option delaunay_elim_on_exit to to potentially skip the last call to delaunay_elim to potentiall avoid deleting boundary elements
- make sure projected fixed points are passed to preserve fixed points in the smoothing operation - avoid repeating cleaning in an infinite loop by not calling when the triangulation is unchanged
|
I think this looks good. Based on the contents of this change, I assume you've also seen the final call to |
|
I tried with and without the final call to |
|
Okay please update the changelog. |
krober10nd
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve_with_reduced_qualitytomeshgenfor allowing for mesh improvements even when quality is decreasing or large number of nodes eliminated, which sometimes is necessary to force the advancement in mesh quality.delaunay_elim_on_exittomeshgento potentially skip the last call to delaunay_elim to potentially avoid deleting boundary elements.