Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default msh.clean options #256

Merged
merged 6 commits into from
Jan 18, 2022
Merged

Default msh.clean options #256

merged 6 commits into from
Jan 18, 2022

Conversation

krober10nd
Copy link
Collaborator

  • Make default smoothing option for msh.clean medium and aggressive models the hill-climbing approach.

* Make default smoothing option for `msh.clean` medium and aggressive models the hill-climbing approach.
@WPringle
Copy link
Collaborator

So generally the quality is the same with this option, but just better preserves the mesh size?

Just interested to know if the examples would all pass with the quality checks.

Copy link
Collaborator

@WPringle WPringle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking to see if tests work as expected

Copy link
Collaborator

@WPringle WPringle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests worked after fix for open boundary subsetting and reduction of quality tolerance in TestSanity.m

@krober10nd krober10nd merged commit 6251e42 into Projection Jan 18, 2022
@krober10nd krober10nd deleted the msh_clean_defaults branch January 18, 2022 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants