Convert prepay managed field into Boolean #155
+8
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related CCI-MOC/nerc-rates#19 |
naved001
reviewed
Mar 7, 2025
| @@ -64,5 +60,5 @@ def _lower_col(data): | |||
| ] | |||
| self.export_data = self.export_data[ | |||
| self.export_data[invoice.INSTITUTION_FIELD].isin(included_institutions) | |||
| | (self.export_data[invoice.GROUP_MANAGED_FIELD].apply(_lower_col) == "yes") | |||
| | (self.export_data[invoice.GROUP_MANAGED_FIELD] == True) # noqa: E712 | |||
There was a problem hiding this comment.
why did you disable E712 instead of doing what it actually says i.e. something is True instead of something == True?
There was a problem hiding this comment.
I somehow forgot that was an option :P
| True | ||
| if group_info[invoice.PREPAY_MANAGED_FIELD].lower() == "yes" | ||
| else False | ||
| ) |
There was a problem hiding this comment.
can be simplified to:
prepay_group_dict[group_name][invoice.PREPAY_MANAGED_FIELD] = (
group_info[invoice.PREPAY_MANAGED_FIELD].lower() == "yes"
)This will also fix a bug in `MOCA_prepaid_invoice`, where `_prepare_export()` previously assumed the `GROUP_MANAGED_FIELD` was a boolean, while in fact it has been a "yes" or "no" string. The prepay test case has been updated.
QuanMPhm
force-pushed
the
bug/prepay_managed_bool
branch
from
ab37f83 to
a66867a
Compare
|
@QuanMPhm what are next steps on this? |
|
@joachimweyl I forgot about this PR. I must have missed it in Zenhub because it wasn't linked to an issue |
|
What I tend to do is turn off issues, filter for author set to myself and then I can see all of the PRs I created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the prepay contacts csv, the
MGHPCC Managedfield contains a "Yes" or "No" string, and would be loaded as a string bypandas.load_csv. Previously, theMOCA_prepaid_invoiceincorrectly assumed theGROUP_MANAGED_FIELDwas a boolean, leading to a bug in billing.Fortunately, we don't have any prepay projects yet, so the impact of this is 0 (other than people's review time (I'm sorry)).
The prepay test case has been updated.