TS conversion for ColorPicker component #15777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
| if (!theme) { | ||
| return "" | ||
| } | ||
| theme = ensureValidTheme(theme, DefaultAppTheme) | ||
| return getThemeClassNames(theme) | ||
| } | ||
|
|
||
| const onChange = value => { | ||
| const onChange = (value: string | null) => { |
There was a problem hiding this comment.
I think we should be trying to get rid of null usage, as under typescript its very specific, undefined should work in all scenarios like this.
There was a problem hiding this comment.
I had this set to auto merge, woops. I will fix this in my next PR, sorry!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Converts ColorPicker component to TS