Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth2 config validation #15753

Merged
merged 10 commits into from
Mar 18, 2025
Merged

OAuth2 config validation #15753

merged 10 commits into from
Mar 18, 2025

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented Mar 17, 2025

Description

Add validation to oauth2 configs

Screenshots

Screen.Recording.2025-03-17.at.13.06.31.mov

Copy link

linear bot commented Mar 17, 2025

Copy link

qa-wolf bot commented Mar 17, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/s labels Mar 17, 2025
@adrinr adrinr marked this pull request as ready for review March 17, 2025 12:09
@adrinr adrinr requested a review from a team as a code owner March 17, 2025 12:09
@adrinr adrinr force-pushed the BUDI-9127/oauth2-config-validation branch from 0c1b681 to 7f8f4cf Compare March 17, 2025 13:09
Base automatically changed from BUDI-9127/oauth2-settings to master March 18, 2025 17:42
Copy link
Collaborator

@mike12345567 mike12345567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice to see zod in the frontend!

@adrinr adrinr enabled auto-merge March 18, 2025 19:37
@adrinr adrinr merged commit 0b72358 into master Mar 18, 2025
22 checks passed
@adrinr adrinr deleted the BUDI-9127/oauth2-config-validation branch March 18, 2025 19:41
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants