Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering updates #15749

Merged
merged 3 commits into from
Mar 14, 2025
Merged

Filtering updates #15749

merged 3 commits into from
Mar 14, 2025

Conversation

aptkingston
Copy link
Member

Description

  • Supports converting nested UI filters with groups into a query. The types allow this, but our code did not correctly convert such filter structures properly
  • Added tests to verify filter > query conversion works for a few cases
  • Tightened up types around filters to enforce that a single SearchFilterGroup may only contain filters or groups, but not both
  • Updated relationship picker to clear options when a filter changes. This fixes an issue where the caching of options meant that options which no longer match the currently applied filter were still being shown
  • Fixed an issue where the type of the filter prop in the relationship picker was wrong. A runtime error would be thrown if you attempted to search while also having a filter applied

Addresses

… types and fix relationship pickers with filters applied caching options incorrectly
Copy link

qa-wolf bot commented Mar 14, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

isArraySearchOperator,
isRangeSearchOperator,
SearchFilter,
UISearchFilter,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Webstorm has decided to sort these alphabetically? Unsure when or how this happened...

@aptkingston aptkingston marked this pull request as ready for review March 14, 2025 15:18
Copy link
Collaborator

@mike12345567 mike12345567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -thanks for the expanded tests as well!

@aptkingston aptkingston merged commit 1c41157 into master Mar 14, 2025
22 checks passed
@aptkingston aptkingston deleted the filtering-updates branch March 14, 2025 16:05
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants