Documentation link in App Action #15684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
mikesealey
changed the title
aptkingston
reviewed
Mar 7, 2025
| aria-hidden="true" | ||
| > | ||
| <use xlink:href="#spectrum-icon-18-LinkOut" /> | ||
| </svg> |
There was a problem hiding this comment.
It would be nicer to use our Icon component (just import it from "../Icon/Icon.svelte"), but it'll function the same! Style wise I would just make it a touch smaller and with a little space between the link and the text.
There was a problem hiding this comment.
Using our icon, you can make it smaller by just doing
<Icon name="LinkOut" size="XS" /> for example.
aptkingston
approved these changes
Mar 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds options for showing a link to relevant documentation in the Inline Alert, as well as implementing this in the "Clear Selected Rows" action.
Addresses
Screenshots
Other implementations of
InlineAlert.svelteremain unchanged