Move snippets to sidepanel #15595
Move snippets to sidepanel #15595
Conversation
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
| @@ -1,5 +0,0 @@ | |||
| export enum SidePanel { | |||
There was a problem hiding this comment.
This is only used in a file, not worth having it in types
| {/if} | ||
| </Layout> | ||
| </div> | ||
|
|
||
| {#if showSnippetDrawer} |
There was a problem hiding this comment.
This is done as it was the easier way to clean the state. Otherwise, when creating multiple snippets, the state would be persisted instead of starting from a clean slate everytime
There was a problem hiding this comment.
Was there any way to work around this? It's not a big problem, but unmounting the component like this when hiding means we lose the drawer close animation - it just instantly disappears with a small flash rather than fading out with an animation.
Not super important but would be a nice to have I guess. Happy to keep it this way since I assume you already tried resetting state instead, but just wanted to note the downside of doing it like this.
adrinr
requested review from
aptkingston and
mike12345567
and removed request for
aptkingston
Good shout. I updated it to handle it internally |
Description
Moving snippets section in bindings in order to match the UX of helpers and other bindings. We discussed keeping the existing section for crud, but this made it harder to understand and to reuse some logic. Happy to discuss improvements and different approaches.
Screenshots
Snippets will be moved to the bindings side panel
Snippets will not appear on the text section
Screen.Recording.2025-02-21.at.12.25.46.mov
Snippets can be added from the side panel
Screen.Recording.2025-02-21.at.12.27.19.mov
Snippets can be edited from the side panel
Screen.Recording.2025-02-21.at.12.27.44.mov
Snippets can be deleted from the side panel
Screen.Recording.2025-02-21.at.12.28.29.mov
Upgrade flow will still be in there for non-licenced users
Screen.Recording.2025-02-21.at.12.36.11.mov
Launchcontrol
Moving snippets section to the binding side panel
Feature branch env
Feature Branch Link