fix: remove deprecated util.isError usage #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryamohanan
force-pushed
the
fix-util-error
branch
from
bd2861e to
2194d05
Compare
aryamohanan
commented
Feb 20, 2025
| @@ -407,7 +407,7 @@ function LibrdKafkaError(e) { | |||
| this.origin = 'kafka'; | |||
| } | |||
| Error.captureStackTrace(this, this.constructor); | |||
| } else if (!util.isError(e)) { | |||
| } else if (!(e instanceof Error || Object.prototype.toString.call(e) === '[object Error]')) { | |||
There was a problem hiding this comment.
util.error removed in v23, see: nodejs/node@dc379626ab
|
@GaryWilber could you please take a look at this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an existing issue #1117 caused by the removal of
util.isError.util.isErrorwas removed in Node.js v23 release, see nodejs/node#52744