Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model] HeCo #204

Merged
merged 86 commits into from
Jun 14, 2024
Merged

[Model] HeCo #204

merged 86 commits into from
Jun 14, 2024

Conversation

tanjjjjrr
Copy link
Contributor

Description

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change,
    or have been fixed to be compatible with this change
  • Related issue is referred in this PR

Changes

@gyzhou2000 gyzhou2000 changed the title Tanjjjjrr new01 HeCo [Model] HeCo May 17, 2024
@dddg617
Copy link
Contributor

dddg617 commented May 20, 2024

  1. Lack the readme.md in the example file, which includes the model performance.
  2. Have you tested the example? I think there should be some bugs, e.g. you do not modify the __init__.py.
  3. There should be docstring in the dataset, your layer/conv, and model.

@tanjjjjrr
Copy link
Contributor Author

  1. Lack the readme.md in the example file, which includes the model performance.
  2. Have you tested the example? I think there should be some bugs, e.g. you do not modify the __init__.py.
  3. There should be docstring in the dataset, your layer/conv, and model.

Thank you for your commendation, I have updated the files mentioned today.

import io
import zipfile
from gammagl.data import download_url
r"""The heterogeneous ACM dataset from the `"Self-supervised Heterogeneous Graph Neural Network with
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error location! Refer to the "document generation guide" and test on your local laptop. This docstring will not generate correctly.

import tensorlayerx.nn as nn
from layers.attention.HeCo_encoder import Mp_encoder
from layers.attention.HeCo_encoder import Sc_encoder
r"""HeCo proposed in `"Self-supervised Heterogeneous Graph Neural Network with Co-contrastive Learning"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for that! I have changed Mp_encoder and Sc_encoder files inside, it has no error on my laptop.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You tried the document generation, not just running the code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might have tried all link relations of the code on my laptop(including data generation etc, while I was running HeCo_trainer.py)and all works well. Could you please give me some hints about the document generation?

@gyzhou2000 gyzhou2000 merged commit 723671f into BUPT-GAMMA:main Jun 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants